Skip to content

chore(claude): commit preview launch config#882

Merged
tannerlinsley merged 1 commit intomainfrom
taren/jolly-darwin-e365e6
May 1, 2026
Merged

chore(claude): commit preview launch config#882
tannerlinsley merged 1 commit intomainfrom
taren/jolly-darwin-e365e6

Conversation

@tannerlinsley
Copy link
Copy Markdown
Member

@tannerlinsley tannerlinsley commented May 1, 2026

Summary

  • Tracks .claude/launch.json (preview server config: web on :3000, db-studio on :4983) so every worktree and fresh branch picks it up automatically
  • Adds .claude/worktrees to .gitignore so the per-worktree subtree never gets accidentally committed

Test plan

  • Pre-commit hook ran: pnpm format && pnpm test && pnpm test:smoke all green
  • git check-ignore .claude/launch.json → not ignored
  • git check-ignore .claude/worktrees → ignored

Summary by CodeRabbit

  • Chores
    • Updated development and debugging configurations for local environment setup.
    • Updated Git ignore rules to exclude local development artifacts.

Track .claude/launch.json so every worktree gets the preview server
config (web on :3000, db-studio on :4983) without re-creating it.
Also ignore .claude/worktrees so the per-worktree subtree never gets
accidentally committed.
@netlify
Copy link
Copy Markdown

netlify Bot commented May 1, 2026

Deploy Preview for tanstack ready!

Name Link
🔨 Latest commit dfd5a91
🔍 Latest deploy log https://app.netlify.com/projects/tanstack/deploys/69f51ea5be87a50007594493
😎 Deploy Preview https://deploy-preview-882--tanstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27 (🔴 down 30 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 97 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

📝 Walkthrough

Walkthrough

Two configuration files are added: a new .claude/launch.json file defining debug launch configurations for development (web on port 3000 and db-studio on port 4983), and an update to .gitignore to exclude .claude/worktrees from version control.

Changes

Cohort / File(s) Summary
Debug Launch Configuration
.claude/launch.json
New debug launch configuration file with two runnable targets: web (pnpm dev on port 3000) and db-studio (pnpm db:studio on port 4983), with version 0.0.1.
Version Control Exclusions
.gitignore
Added .claude/worktrees to gitignore to exclude worktrees directory from Git tracking.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 With whiskers twitching, I adjust the configs,
Launch ports set for debugging's quick tricks,
Worktrees hidden from git's keen sight,
The dev burrow's now configured just right!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a new .claude/launch.json configuration file to version control to provide preview server settings for the Claude environment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch taren/jolly-darwin-e365e6

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.claude/launch.json (1)

11-15: Consider explicitly passing --port 4983 to drizzle-kit studio for clarity.

drizzle-kit studio binds to port 4983 by default, so the current configuration works. However, the port field in launch.json is used for preview routing and does not automatically configure the underlying process. To make it explicit that the service and launch config are synchronized, update runtimeArgs to:

"runtimeArgs": ["db:studio", "--", "--port", "4983"]

This ensures that if the port in launch.json changes in the future, the actual service port is also explicitly updated, avoiding accidental misconfiguration.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.claude/launch.json around lines 11 - 15, Update the "db-studio" launch
configuration so the actual drizzle-kit process receives the port flag: modify
the runtimeArgs array used by the "db-studio" entry (the runtimeArgs property)
to append an explicit "--", "--port", "4983" so the launched process is
explicitly bound to port 4983 and stays in sync with the launch.json port field.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.claude/launch.json:
- Around line 11-15: Update the "db-studio" launch configuration so the actual
drizzle-kit process receives the port flag: modify the runtimeArgs array used by
the "db-studio" entry (the runtimeArgs property) to append an explicit "--",
"--port", "4983" so the launched process is explicitly bound to port 4983 and
stays in sync with the launch.json port field.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7ea9d7b2-e715-4651-a8b7-d53afbc4bf5c

📥 Commits

Reviewing files that changed from the base of the PR and between f1dec64 and dfd5a91.

📒 Files selected for processing (2)
  • .claude/launch.json
  • .gitignore

@tannerlinsley tannerlinsley merged commit 74f1b3b into main May 1, 2026
8 checks passed
@tannerlinsley tannerlinsley deleted the taren/jolly-darwin-e365e6 branch May 1, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant